Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: the runtime-v1 version shouldn't use v2 types #266

Open
ibodrov opened this issue Dec 7, 2020 · 0 comments
Open

ansible: the runtime-v1 version shouldn't use v2 types #266

ibodrov opened this issue Dec 7, 2020 · 0 comments

Comments

@ibodrov
Copy link
Collaborator

ibodrov commented Dec 7, 2020

Currently the task re-uses TaskResult from the concord-v2 runtime for the common code that can be called from both v1 and v2 runtimes. Due to breaking changes in 1.71.0, this might cause errors like so:

java.lang.InstantiationError: com.walmartlabs.concord.runtime.v2.sdk.TaskResult
	at com.walmartlabs.concord.plugins.ansible.AnsibleTask.run(AnsibleTask.java:153)
	at com.walmartlabs.concord.plugins.ansible.v1.RunPlaybookTask2.run(RunPlaybookTask2.java:127)

We need to change the task to not to use v2 types in common code bits and avoid situations like this in future.

@brig brig self-assigned this Dec 7, 2020
@brig brig removed their assignment Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants