Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto play next article not working on Android 10 and above #1312

Open
KevinSJ opened this issue May 19, 2023 · 0 comments
Open

Auto play next article not working on Android 10 and above #1312

KevinSJ opened this issue May 19, 2023 · 0 comments

Comments

@KevinSJ
Copy link

KevinSJ commented May 19, 2023

Issue details

Duplicate?

No

Actual behaviour

  • When the app is the backgroud, even when the Auto Play Next is selected, the app will not play the next article automatically. The notification will become "...", and a page turning sound will be played, but no article starts playing.

Expected behaviour

  • The app should continue play the next article even when when it's in background.

Steps to reproduce the issue

  1. Find any article.
  2. Start text-to-speech, tick auto play next.
  3. Put the app in background and wait till tts finish the current article.

Environment details

  • wallabag app version: 2.4.3
  • wallabag app installation source (e.g. Gplay, F-Droid, manual): F-Droid
  • Android OS version: Android 13
  • Android ROM (e.g. stock, LineageOS, SlimRom,…): Samsung OneUI
  • Android hardware: Samsung Galaxy S23+
  • wallabag server version:
  • Do you have Two-Factor-Authentication enabled?: no

Logs

wallabag server

Not relevant

Web server

Not relvant

Your experience with wallabag Android app

Really like it, have been using for more than a year, thanks for creating this app.

My Thoughts and Ideas

This functionality works well on my other Android device with Android 9, and [based on this],(https://developer.android.com/guide/components/activities/background-starts), it is a OS change that caused this.
The current app will try to start activity from the background here, but it will fail because of the new change in Android 10 and above.

I had some rough ideas on what changes should be implemented, and actually had actually done the implementation locally. What I had done is to ask the user to allow draw on other app permission, if they allow the permission, the app would be able to start the ReadArticleActivity from background and therefore the next article would be read.

However, what I'm not sure about:

  1. where and when should the app ask the user for the draw on other app permsision? (Currently I put it in MainActivity, which I'm not sure is a good idea or not, cause my android dev knowledge is very limited)
  2. what should be done if the user do not allow the permisson? (Maybe send a toast?)

I'm willing to create a PR if I can get some help on the questions above (or I can create a PR based on whatever I have at the moment which is partially based on code from ChatGPT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant