setuptools_scm_git_archive is still needed as dependency?

[rurigk]

https://pypi.org/project/setuptools-scm-git-archive/

Says This plugin is obsolete. ``setuptools_scm >= 7.0.0`` supports Git archives by itself .

setuptools_scm_git_archive is still needed as dependency?

I understand that it might be needed for backwards compatibility

setuptools_scm version by distro
Arch Linux -> 7.1.0
Debian Sid -> 7.1.0
Debian 11 backports -> 7.0.4
Debian 11 -> 5.0.1
Debian 10 -> 3.2.0
Ubuntu 23.04 -> 7.1.0
Ubuntu 22.10 -> 7.0.5
Ubuntu 22.04 -> 6.4.2

[djhoese]

I was pretty sure I explored dropping this dependency for other packages I maintain, but right now I can't find one where it was removed. I don't think it matters what setuptools_scm you find on your system as the use of pyproject.toml should create an isolated build environment with its own copy of packages installed, then copy the resulting built package (vispy) to your final environment.

If you want to throw a pull request together to try removing it @rurigk, we can see what happens. I don't remember last time I researched it if there were any other changes needed. You could always force the version of setuptools_scm in pyproject.toml too.

[rurigk]

@djhoese the reason of this issue is because a time ago i was trying to use https://aur.archlinux.org/packages/flatcam-qt6
Which depends on https://aur.archlinux.org/packages/python-vispy

But the package for vispy fails to build because there is no setuptools_scm_git_archive in the arch official repos anymore because setuptools_scm >= 7.0.0 already provides the functionality

Removing setuptools_scm_git_archive makes vispy build in Arch and the package flatcam-qt6 i wanted to use works

I tried to send a pull request to the package https://aur.archlinux.org/packages/python-vispy to just remove the setuptools_scm_git_archive to avoid messing with vispy compatibility but the mantainer requires the changes are made in upstream

And if setuptools_scm_git_archive is removed here it needs testing, but i'm not a python dev, and my knowledge of python is very limited

[djhoese]

It does not need additional tests or even python code changes. Only pyproject.toml changes. Tests will be run automatically and our release process will reveal anything else. If you are really not comfortable with doing this, I can try to start a PR tomorrow if I find the time.

[rurigk]

Its only necessary to change it on pyproject.toml or setup.py is required as well?

vispy/pyproject.toml

Line 9 in e71b275

"setuptools_scm_git_archive",

vispy/setup.py

Line 97 in e71b275

setup_requires=['numpy', 'cython', 'setuptools_scm', 'setuptools_scm_git_archive', 'packaging'],

[djhoese]

I think now that the pyproject.toml exists the setup_requires is actually ignored by pip. The entire setup requires could probably be removed from setup.py.