Callback method name typo in ChainTransform.__setitem__()

[nnop]

vispy/vispy/visuals/transforms/chain.py

Lines 212 to 217 in 525504a

	def __setitem__(self, index, tr):
	self._transforms[index].changed.disconnect(self._subtr_changed)
	self._transforms[index] = tr
	tr.changed.connect(self.subtr_changed)
	self._rebuild_shaders()
	self.update()

L215 misspelled _subtr_changed to subtr_changed. But everything seems work well. What would that affect?

[djhoese]

Hhhmmm interesting. Thanks for bringing this up. It would suggest that this entire __setitem__ functionality is not used nor tested in vispy. Accessing self.subtr_changed should cause an AttributeError because it shouldn't exist.

How do you feel about creating a pull request to fix this typo at least?

[djhoese]

Bonus points if you can add a test that uses the functionality!