feat(payments-plugin): Allow mollie orders with $0 #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for effervescent-donut-4977b2 failed.
|
|
The mySQL test fails with @vendure/core: FAIL e2e/shop-order.e2e-spec.ts > Shop orders
@vendure/core: Error: listen EADDRINUSE: address already in use :::3012So, that seems like a concurrency thing, not an issue with the PR per se |
michaelbromley
merged commit b54c210
into
vendure-ecommerce:master
10 of 16 checks passed
|
Thanks! |
gdarchen
pushed a commit
to gdarchen/vendure
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transition orders to PaymentSettled when the total is $0. The payment intent returns the given thank-you/confirmation page instead of the link to Mollie, because we don't need to redirect the customer to the Mollie platform.
Closes #2821
Checklist
📌 Always:
👍 Most of the time: