Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xenorchestra_vdi data source implicitly requires pool_id #169

Open
ddelnano opened this issue Aug 11, 2021 · 0 comments
Open

xenorchestra_vdi data source implicitly requires pool_id #169

ddelnano opened this issue Aug 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ddelnano
Copy link
Collaborator

After debugging the following situation with a user in discord (link), I realized that the xenorchestra_vdi data source implicitly requires a pool_id argument. The problem is this code here that only allows VDI objects to match by name_label if the pool_id matches as well.

This is confusing since the documentation states that filtering by name_label alone should work as long as there aren't multiple results returned. We should see if its possible to fix the logic in the VDI.Compare method.

@ddelnano ddelnano added the bug Something isn't working label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant