Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad filing on Ensembl #123

Open
siebrenf opened this issue Aug 28, 2020 · 1 comment · Fixed by #132
Open

bad filing on Ensembl #123

siebrenf opened this issue Aug 28, 2020 · 1 comment · Fixed by #132

Comments

@siebrenf
Copy link
Member

Bakers yeast is one of those model organisms you would expect to be used a lot.
Unfortunately, the filing system for this genome, and at least several other fungi is inconsistent.

Provider: Ensembl
example genome: ASM280432v1

expected: ftp://ftp.ensemblgenomes.org/pub/fungi/release-48/fasta/saccharomyces_cerevisiae/dna/Saccharomyces_cerevisiae.dna_sm.toplevel.fa.gz

genomepy: ftp://ftp.ensemblgenomes.org/pub/fungi/release-48/fasta/saccharomyces_cerevisiae_gca_002804325/dna/Saccharomyces_cerevisiae_gca_002804325.ASM280432v1.dna_sm.toplevel.fa.gz

real: ftp://ftp.ensemblgenomes.org/pub/fungi/release-48/fasta/saccharomyces_cerevisiae/dna/Saccharomyces_cerevisiae.R64-1-1.dna_sm.toplevel.fa.gz

The error lies in url_name, which is given by Ensembl. We could change this to look for a partial match instead of an exact match.

@simonvh
Copy link
Member

simonvh commented Aug 28, 2020

Add this to a FAQ / known issues. Don't spend a lot of time on fixing this. Genomepy also won't work well for bacteria.

@siebrenf siebrenf linked a pull request Sep 11, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants