Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about train.py #9

Open
xiaolonghao opened this issue Sep 16, 2020 · 1 comment
Open

about train.py #9

xiaolonghao opened this issue Sep 16, 2020 · 1 comment

Comments

@xiaolonghao
Copy link

Hello, look at your code, feel some questions. It's on line 114 of train.py, i.e. values = torch.cat(values).detach(). I think this statement should come after line 123. In line 120, i.e., gae = gae + reward + opt.gamma * next_value.detach() * (1 - done) - value.detach(). It will become a constant(size=1) instead of a vector(size=8). You can check it and solve my question. Thank you.

@zhuzhu18
Copy link

I think it should be as you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants