Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS in "npm install" #119

Open
onlyjob opened this issue Dec 1, 2020 · 1 comment
Open

FTBFS in "npm install" #119

onlyjob opened this issue Dec 1, 2020 · 1 comment

Comments

@onlyjob
Copy link

onlyjob commented Dec 1, 2020

Current "master" FTBFS in npm install as follows:

$ npm install                                                             
npm WARN ERESOLVE overriding peer dependency
npm WARN Found: react@17.0.1
npm WARN node_modules/react
npm WARN   peer react@"*" from @storybook/addon-viewport@5.3.21
npm WARN   node_modules/@storybook/addon-viewport
npm WARN     dev @storybook/addon-viewport@"^5.0.6" from the root project
npm WARN   2 more (@storybook/theming, react-dom)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"15.x || 16.x || 16.4.0-alpha.0911da3" from @reach/router@1.3.4
npm WARN node_modules/@reach/router
npm WARN   @reach/router@"^1.2.1" from @storybook/router@5.3.21
npm WARN   node_modules/@storybook/router
npm WARN   1 more (@storybook/api)
npm WARN ERESOLVE overriding peer dependency
npm WARN Found: react-dom@17.0.1
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"*" from @storybook/theming@5.3.21
npm WARN   node_modules/@storybook/theming
npm WARN     @storybook/theming@"5.3.21" from @storybook/addon-viewport@5.3.21
npm WARN     node_modules/@storybook/addon-viewport
npm WARN     2 more (@storybook/api, @storybook/components)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"15.x || 16.x || 16.4.0-alpha.0911da3" from @reach/router@1.3.4
npm WARN node_modules/@reach/router
npm WARN   @reach/router@"^1.2.1" from @storybook/router@5.3.21
npm WARN   node_modules/@storybook/router
npm WARN   1 more (@storybook/api)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: react@17.0.1
npm ERR! node_modules/react
npm ERR!   peer react@"*" from @storybook/addon-viewport@5.3.21
npm ERR!   node_modules/@storybook/addon-viewport
npm ERR!     dev @storybook/addon-viewport@"^5.0.6" from the root project
npm ERR!   peer react@"*" from @storybook/theming@5.3.21
npm ERR!   node_modules/@storybook/theming
npm ERR!     @storybook/theming@"5.3.21" from @storybook/addon-viewport@5.3.21
npm ERR!     node_modules/@storybook/addon-viewport
npm ERR!       dev @storybook/addon-viewport@"^5.0.6" from the root project
npm ERR!     @storybook/theming@"5.3.21" from @storybook/api@5.3.21
npm ERR!     node_modules/@storybook/api
npm ERR!       @storybook/api@"5.3.21" from @storybook/addon-viewport@5.3.21
npm ERR!       node_modules/@storybook/addon-viewport
npm ERR!         dev @storybook/addon-viewport@"^5.0.6" from the root project
npm ERR!       1 more (@storybook/addons)
npm ERR!     1 more (@storybook/components)
npm ERR!   1 more (react-dom)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from create-react-context@0.3.0
npm ERR! node_modules/@reach/router/node_modules/create-react-context
npm ERR!   create-react-context@"0.3.0" from @reach/router@1.3.4
npm ERR!   node_modules/@reach/router
npm ERR!     @reach/router@"^1.2.1" from @storybook/router@5.3.21
npm ERR!     node_modules/@storybook/router
npm ERR!       @storybook/router@"5.3.21" from @storybook/api@5.3.21
npm ERR!       node_modules/@storybook/api
npm ERR!     1 more (@storybook/api)
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

npm install --legacy-peer-deps succeeds...

@pablojimpas
Copy link
Member

pablojimpas commented Feb 26, 2021

Similar results on branch v.1.7.2

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: react@17.0.1
npm ERR! node_modules/react
npm ERR!   peer react@"*" from @storybook/addon-viewport@5.0.6
npm ERR!   node_modules/@storybook/addon-viewport
npm ERR!     dev @storybook/addon-viewport@"^5.0.6" from the root project
npm ERR!   peer react@"*" from @storybook/components@5.0.6
npm ERR!   node_modules/@storybook/components
npm ERR!     @storybook/components@"5.0.6" from @storybook/addon-viewport@5.0.6
npm ERR!     node_modules/@storybook/addon-viewport
npm ERR!       dev @storybook/addon-viewport@"^5.0.6" from the root project
npm ERR!   3 more (react-dom, @storybook/theming, @storybook/router)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0 || ^16.0.0" from react-focus-lock@1.18.3
npm ERR! node_modules/@storybook/components/node_modules/react-focus-lock
npm ERR!   react-focus-lock@"^1.17.7" from @storybook/components@5.0.6
npm ERR!   node_modules/@storybook/components
npm ERR!     @storybook/components@"5.0.6" from @storybook/addon-viewport@5.0.6
npm ERR!     node_modules/@storybook/addon-viewport
npm ERR!       dev @storybook/addon-viewport@"^5.0.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

It will be nice to reduce the number of Javascript dependencies to make them easier to manage. Also having a some kind of bot in the repo for keeping dependencies up to date and CI/CD should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants