Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm] TextBox in ListView does not accept spaces #16655

Closed
jeromelaban opened this issue May 9, 2024 · 3 comments · Fixed by #16683
Closed

[Wasm] TextBox in ListView does not accept spaces #16655

jeromelaban opened this issue May 9, 2024 · 3 comments · Fixed by #16683
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...)

Comments

@jeromelaban
Copy link
Member

Current behavior

In https://playgroundcanary.z19.web.core.windows.net/#203f248a, it's not possible to add spaces to a TextBox.

Expected behavior

Spaces are accepted.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

None

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

5.2.102

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@jeromelaban jeromelaban added kind/bug Something isn't working platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...) difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 9, 2024
@jeromelaban
Copy link
Member Author

This may be related to

uno/src/Uno.UI/UI/Xaml/Controls/ListViewBase/ListViewBase.cs

Line 97 in ef7b6a1

args.Key == VirtualKey.Space)

@dr1rrb
Copy link
Member

dr1rrb commented May 9, 2024 •
edited

This may be related to

https://github.com/unoplatform/uno/blob/ef7b6a1e4e640f1fb9d702d3d3c5a92aff594cf0/src/Uno.UI/UI/Xaml/Controls/

If so, as this is on bubbling, we should probably just make sure that flagging this key event as handled does not cause the preventDefault() in native.

cf. https://github.com/unoplatform/uno/blob/ef7b6a1e4e640f1fb9d702d3d3c5a92aff594cf0/src/Uno.UI/UI/Xaml/HtmlEventDispatchResult.wasm.cs

@jsinsel-kahua
Copy link

We'll also need Enter to behave properly for cases where the TextBox has AcceptsReturn.

@dr1rrb dr1rrb mentioned this issue May 10, 2024
Merged
6 tasks
@mergify mergify bot mentioned this issue May 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix space and enter keys in TB while in ListView unoplatform/uno
3 participants
@jeromelaban @dr1rrb @jsinsel-kahua