Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneratePackageOnBuild ignored in Uno.Sdk #16572

Closed
mikernet opened this issue May 3, 2024 · 1 comment · Fixed by #16651
Closed

GeneratePackageOnBuild ignored in Uno.Sdk #16572

mikernet opened this issue May 3, 2024 · 1 comment · Fixed by #16651
Assignees
@dansiegel
Labels
area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working

Comments

@mikernet
Copy link
Contributor

mikernet commented May 3, 2024

Current behavior

Putting <GeneratePackageOnBuild>true</GeneratePackageOnBuild> in an single-project Uno.Sdk library appears to be ignored.

Expected behavior

Package should be generated on build

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

Set IsPackable to true + generate package via cli

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia

NuGet package version(s)

Latest 5.2.x

Affected platforms

No response

IDE

Visual Studio 2022

IDE version

Latest

Relevant plugins

No response

Anything else we need to know?

No response
@mikernet mikernet added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels May 3, 2024
@mikernet
Copy link
Contributor Author

mikernet commented May 3, 2024

Related:

SDK-style projects have the pack functionality available by default. For non SDK-style PackageReference projects, you need to add the NuGet.Build.Tasks.Pack package to the project dependencies.

(from: https://learn.microsoft.com/en-us/nuget/create-packages/creating-a-package-msbuild)

Would be nice if Uno.Sdk did this to avoid migration headaches.

@Youssef1313 Youssef1313 added the area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk label May 4, 2024
@dansiegel dansiegel self-assigned this May 6, 2024
@dansiegel dansiegel added ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met and removed triage/untriaged Indicates an issue requires triaging or verification ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met labels May 6, 2024
@dansiegel dansiegel mentioned this issue May 9, 2024
Merged
@mergify mergify bot mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dansiegel dansiegel

Labels
area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SDK ignores GeneratePackageOnBuild unoplatform/uno
3 participants
@mikernet @dansiegel @Youssef1313