Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X11] Switch from DllImports to LibraryImports for better performance #16554

Closed
Youssef1313 opened this issue May 2, 2024 · 1 comment · Fixed by #16556
Closed

[X11] Switch from DllImports to LibraryImports for better performance #16554

Youssef1313 opened this issue May 2, 2024 · 1 comment · Fixed by #16556
Assignees
@Youssef1313
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

What would you like to be added

All bindings should be switched to LibraryImport:

https://github.com/unoplatform/uno/blob/2ea1c54b08f22b37e7a5ebf73d3049c4538687f1/src/Uno.UI.Runtime.Skia.X11/X11_Bindings/x11bindings_Glx.cs
https://github.com/unoplatform/uno/blob/2ea1c54b08f22b37e7a5ebf73d3049c4538687f1/src/Uno.UI.Runtime.Skia.X11/X11ApplicationHost.cs
https://github.com/unoplatform/uno/blob/2ea1c54b08f22b37e7a5ebf73d3049c4538687f1/src/Uno.UI.Runtime.Skia.X11/X11_Bindings/x11bindings_XLib.cs
https://github.com/unoplatform/uno/blob/2ea1c54b08f22b37e7a5ebf73d3049c4538687f1/src/Uno.UI.Runtime.Skia.X11/X11_Bindings/X11Helper.cs

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 2, 2024
@Youssef1313 Youssef1313 self-assigned this May 2, 2024
@Youssef1313 Youssef1313 added the area/performance 📈 Categorizes an issue or PR as relevant to performance label May 2, 2024
@Youssef1313 Youssef1313 mentioned this issue May 2, 2024
Merged
6 tasks
@ramezgerges
Copy link
Contributor

I have quite a few X11 PRs open, so let's put this one on hold until they merge so I don't have to deal with a million conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Update X11 bindings to LibraryImport Youssef1313/uno
2 participants
@Youssef1313 @ramezgerges