Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidateRender unnecessarily boxes List<T> enumerators #16540

Open
Youssef1313 opened this issue May 1, 2024 · 0 comments
Open

InvalidateRender unnecessarily boxes List<T> enumerators #16540

Youssef1313 opened this issue May 1, 2024 · 0 comments
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request

Comments

@Youssef1313
Copy link
Member

What would you like to be added

uno/src/Uno.UI/UI/Xaml/Application.skia.cs

Line 39 in 5a5de6c

foreach (var cRoot in CoreServices.Instance.ContentRootCoordinator.ContentRoots)

As ContentRoots is an IReadOnlyList<T>, the enumerator will be boxed. This is unnecessary and is easy to optimize.

image

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. area/performance 📈 Categorizes an issue or PR as relevant to performance labels May 1, 2024
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromelaban @Youssef1313