Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit / Simplify MtouchExtraArgs for iOS & MacCatalyst targets #413

Open
dansiegel opened this issue Nov 7, 2023 · 0 comments
Open

Audit / Simplify MtouchExtraArgs for iOS & MacCatalyst targets #413

dansiegel opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
kind/enhancement New feature or request. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@dansiegel
Copy link
Contributor

Description

Currently the Mobile head has several additions for the MtouchExtraArgs. MtouchExtraArgs are black magic to a lot of developers and not overly well documented. We should avoid having MtouchExtraArgs unless they are absolutely necessary. Especially considering that both of the extra MtouchExtraArgs that have a reference to an issue link to a closed issue these need to be updated. These should be updated as follows:

  1. Removed if no longer needed for net7 and net8
  2. Wrapped in a template condition if it is required for net7 but not for net8
  3. Each argument should have a reference issue or description for why we are adding it
<!-- Configure the GC -->
<MtouchExtraArgs>$(MtouchExtraArgs) --setenv=MONO_GC_PARAMS=soft-heap-limit=512m,nursery-size=64m,evacuation-threshold=66,major=marksweep,concurrent-sweep</MtouchExtraArgs>

<!-- See https://github.com/unoplatform/uno/issues/9430 for more details. -->
<MtouchExtraArgs>$(MtouchExtraArgs) --registrar:static</MtouchExtraArgs>

<PropertyGroup Condition="'$(Configuration)'=='Release'">
  <!-- https://github.com/xamarin/xamarin-macios/issues/14812 -->
  <MtouchExtraArgs>$(MtouchExtraArgs) --marshal-objectivec-exceptions:disable</MtouchExtraArgs>
</PropertyGroup>
@dansiegel dansiegel added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Nov 7, 2023
@nickrandolph nickrandolph added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed triage/untriaged Indicates an issue requires triaging or verification. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants