Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Extensions] Remove explicit WindowsAppSdk reference #2235

Open
dansiegel opened this issue Apr 4, 2024 · 0 comments
Open

[All Extensions] Remove explicit WindowsAppSdk reference #2235

dansiegel opened this issue Apr 4, 2024 · 0 comments
Labels
kind/enhancement New feature or request.

Comments

@dansiegel
Copy link
Contributor

Current behavior

Currently all Uno.Extensions packages get an explicit reference to Microsoft.WindowsAppSdk.

<When Condition="$(_IsWinUI)">
<ItemGroup>
<PackageReference Include="Microsoft.WindowsAppSDK" Condition="$(WinAppSdkVersion)==''"/>
<PackageReference Include="Microsoft.WindowsAppSDK" Condition="$(WinAppSdkVersion)!=''" VersionOverride="$(WinAppSdkVersion)"/>
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" />
</ItemGroup>
</When>

Expected behavior

This should come through transitively from Uno.WinUI and only be explicitly provided if there is an explicit reason that we need a newer version.

@dansiegel dansiegel added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Apr 4, 2024
@nickrandolph nickrandolph added kind/enhancement New feature or request. and removed kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels May 7, 2024
@nickrandolph nickrandolph changed the title Remove explicit WindowsAppSdk reference [All Extensions] Remove explicit WindowsAppSdk reference May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants