Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hosting] Extensions should not require LaunchActivatedEventArgs #2222

Open
6 tasks
MartinZikmund opened this issue Mar 29, 2024 · 0 comments
Open
6 tasks
Labels
kind/bug Something isn't working priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@MartinZikmund
Copy link
Member

Current behavior

Currently builder requires LaunchActivatedEventArgs, which means it is unusable if the app is launched via any non-launch path - e.g. OnActivated via protocol activation or jumplist (in these cases OnLaunched never executes). Instead, it should either be possible to initialize the host without any arguments (it seems to me that it does not even use them currently?) or provide alternatives, e.g. IActivatedEventArgs

Expected behavior

Should be possible to use with OnActivated execution path.

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package (s):

Package Version(s):

Affected platform(s):

All

Visual Studio:

  • 2019 (version: )
  • 2022 (version: )
  • Visual Studio Code (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed triage/untriaged Indicates an issue requires triaging or verification. labels Mar 29, 2024
@nickrandolph nickrandolph changed the title Extensions should not require LaunchActivatedEventArgs [Hosting] Extensions should not require LaunchActivatedEventArgs May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

1 participant