Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hosting] Adjust Application Host builder create window #2190

Closed
dansiegel opened this issue Feb 29, 2024 · 1 comment
Closed

[Hosting] Adjust Application Host builder create window #2190

dansiegel opened this issue Feb 29, 2024 · 1 comment
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.

Comments

@dansiegel
Copy link
Contributor

What would you like to be added:

This should be updated as the proper way to do this in Uno has changed:

uno.extensions/src/Uno.Extensions.Hosting.UI/ApplicationBuilder.cs

Lines 10 to 14 in 51c9c1e

#if NET6_0_OR_GREATER && WINDOWS && !HAS_UNO
new Window();
#else
Window.Current;
#endif

We should instead just return new Window()

Why is this needed:

Multi-Window
@dansiegel dansiegel added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Feb 29, 2024
@nickrandolph nickrandolph changed the title Adjust Application Host builder create window [Hosting] Adjust Application Host builder create window May 7, 2024
@nickrandolph
Copy link
Contributor

Fixed by #2246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickrandolph @dansiegel