Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Interpolate func updated #28464

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

Sanjay8602
Copy link

@Sanjay8602 Sanjay8602 commented Mar 1, 2024

PR Description

Related Issue

Closes #26133

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@Sanjay8602 Sanjay8602 marked this pull request as ready for review March 2, 2024 20:10
@Sanjay8602
Copy link
Author

Hey @Ishticode please review this PR

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sanjay8602
Thanks for the PR.
Could you briefly explain what this PR is meant to fix or add?
The changes currently made here has the test_interpolate for paddle failing as may be seen in the logs at https://github.com/unifyai/ivy/actions/runs/8178817582/job/22363875444?pr=28464
Let me know if something is unclear. Thanks :)

@Sanjay8602
Copy link
Author

Hi @Sanjay8602 Thanks for the PR. Could you briefly explain what this PR is meant to fix or add? The changes currently made here has the test_interpolate for paddle failing as may be seen in the logs at https://github.com/unifyai/ivy/actions/runs/8178817582/job/22363875444?pr=28464 Let me know if something is unclear. Thanks :)

In this issue the interpolate function was created but it needed the updation so I just deleted the exception and added 4-5 lines.
But I am getting 2-3 error in checks ex: check 8 and 9 where I am getting error but I am not able undrstand it plz help...

@Sanjay8602
Copy link
Author

Hi @Sanjay8602 Thanks for the PR. Could you briefly explain what this PR is meant to fix or add? The changes currently made here has the test_interpolate for paddle failing as may be seen in the logs at https://github.com/unifyai/ivy/actions/runs/8178817582/job/22363875444?pr=28464 Let me know if something is unclear. Thanks :)

test function is already created for this in test_layers file

@Ishticode
Copy link
Contributor

Ishticode commented Mar 14, 2024

Hi @Sanjay8602
Which exception did you remove? Currently i don't see any under changes.
And yes the test is already there but it has started to fail with changes on the PR. We would need to ensure it passes to continure. Please check details at our Contributing Page.

@Sanjay8602 Sanjay8602 marked this pull request as draft March 28, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpolate
4 participants