Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predictable temporary file name TOCTOU #4269

Open
mathstuf opened this issue Apr 5, 2024 · 1 comment
Open

Predictable temporary file name TOCTOU #4269

mathstuf opened this issue Apr 5, 2024 · 1 comment
Labels
Engineering Anything to do with building/releasing/deploying uncrustify; with CI; or with the test framework.

Comments

@mathstuf
Copy link

mathstuf commented Apr 5, 2024

uncrustify uses a predictable filename when using --replace. This means that if multiple uncrustify processes are working on the same file, they may each try to rename this predictable name on each other. I've fixed the tool I discovered the problem with to not try to reformat the same file concurrently, but I thought this might be of interest here in any case.
@gmaurel gmaurel added the Engineering Anything to do with building/releasing/deploying uncrustify; with CI; or with the test framework. label Apr 19, 2024
@gmaurel
Copy link
Collaborator

gmaurel commented Apr 19, 2024

yes, please make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering Anything to do with building/releasing/deploying uncrustify; with CI; or with the test framework.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathstuf @gmaurel