Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patching Duckling #144

Merged
merged 6 commits into from
May 23, 2019
Merged

Patching Duckling #144

merged 6 commits into from
May 23, 2019

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented May 22, 2019

  • I had to mark unbuildable the components
    • duckling-regen-exe: needed to generate the haskell files (i think): it uses haskell-src-exts and reach the class size limit
    • duckling-example-exe: it uses snap-core
  • I've not tested it at runtime

Fixes #143

@jneira jneira requested a review from rahulmutt May 22, 2019 19:41
@jneira jneira mentioned this pull request May 22, 2019
Open
rahulmutt
rahulmutt approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@rahulmutt rahulmutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the patches, @jneira!

@rahulmutt rahulmutt merged commit 716bae2 into typelead:master May 23, 2019
@jneira jneira deleted the duckling branch May 28, 2019 22:22
@argideritzalpea
Copy link

argideritzalpea commented May 28, 2019 •
edited

Hi @jneira - please forgive my ignorance, but is snap-core inherently incompatible with 'eta' or would it require its own patch? We are hoping to use duckling-example-exe in our application.

I got 'duckling-test' to build successfully

but does not pass the unit tests:

Duckling Tests
  API Tests
    Parse Test:                    FAIL
      Exception: WrapPCRE.hsc was not compiled against pcre library with HAVE_PCRE_H defined
    Rank Tests
      Rank Filter Tests:           FAIL
        Exception: JException java.lang.NullPointerException
      Rank Order Tests:            FAIL
        Exception: WrapPCRE.hsc was not compiled against pcre library with HAVE_PCRE_H defined
    Range Tests:                   FAIL
      Exception: WrapPCRE.hsc was not compiled against pcre library with HAVE_PCRE_H defined

...

@jneira
Copy link
Collaborator Author

jneira commented May 29, 2019

No worries! snap could be patched for eta (like warp/wai) but maybe it could be quite work. However i will give a try to confirm it.
I'll take a look to test suite errors, i hope it can be fixed without too much problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulmutt rahulmutt rahulmutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Duckling to work
3 participants
@jneira @argideritzalpea @rahulmutt