Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Virtual" connection identifier should be a UUID4, not an integer counter #47

Open
glyph opened this issue Dec 20, 2016 · 4 comments
Open

Comments

@glyph
Copy link
Member

glyph commented Dec 20, 2016

glyph did not know things about cryptographic security when he wrote this

@glyph
Copy link
Member Author

glyph commented Dec 20, 2016

The relevant AMP command is in vertex.command.Virtual

@glyph
Copy link
Member Author

glyph commented Dec 20, 2016

Choke and Unchoke both refer to the same kind of connection ID

@glyph
Copy link
Member Author

glyph commented Dec 20, 2016

There's also a couple of callRemoteString invocations which imply AMP commands on vertex.q2q.VirtualTransport and the amp_WRITE and amp_CLOSE methods on Q2Q.

@glyph
Copy link
Member Author

glyph commented Jan 2, 2017

This might not actually be necessary. The comment about cryptographic security above was somewhat misguided, since the identifiers are scoped to the (authenticated) connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant