-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak with Twisted 24.3.0 #12120
Comments
Thanks Vivek for the report. Can you please share the code of your application that is triggering the memory leak? A short, self contained example would help a lot. Regards |
It's quite possible that this is a bug in Twisted but this is not enough information to act on it; it's possible that it's just your application, or perhaps a patch that Debian applied, given that it appears to be installed with dpkg rather than pip. We'd love to fix it, so please do resubmit if you can narrow it down to a reproducer! |
It would be a bit difficult to provide self contained example as my application code is tightly coupled and it will take a lot of effort.
Let me know if this would help. |
It's possible that the Deferred debugging / Failure cleaning logic was unintentionally changed subtly, because that can depend intimately on the details of garbage collection, which is hard to have a test for. That might be a place to investigate in the application being discussed, i.e., does it have a bunch of circular and/or uncollectable references which might be generating cycles in the face of some subtle change there? Another thing to check in this general area of hypotheses is, "is there anything in |
Thanks @adiroiban for pointing out df9d19c merge commit. Pointed trunk to 64506ce (where the memory leak was observed for me) and then reverted the changes of df9d19c and with this I'm not seeing memory leak. |
Perfect. So the regression was introduced in df9d19c I think that we have a better starting point for troubleshooting :) |
Is there any update on this? -Thanks |
@vanand123 If anyone has updates, they will surely post them here. In the meanwhile, a minimal reproducer would go a long way to make this feasible to investigate more easily. |
Describe the incorrect behavior you saw
My REST application's memory keeps increasing indefinitely with Twisted 24.3.0.
Describe how to cause this behavior
What did you do to get it to happen?
With the rest load, my rest application's memory keeps increasing.
Does it happen every time you follow these steps, sometimes, or only one time?
This happens every time.
After further investigation, I discovered that my application memory was fine with Twisted 21.2.0.
This issue started occurring with Twisted 21.7.0rc1 onwards.
Describe the correct behavior you'd like to see
With the rest load, memory of application should not increase indefinitely.
Testing environment
The text was updated successfully, but these errors were encountered: