#571 Use pre-commit dog food and update release process for pre-commit autoupdate. #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hynek
reviewed
Dec 20, 2023
|
I don't think #571 is on our side tbh, but dogfooding is good regardless. |
adiroiban
changed the title
adiroiban
changed the title
|
I don't have time to look into this. If anyone cares about pre-commit, feel free to send a fix. This PR demonstrates the issue and I hope that it can be use to test the fix :) |
7 tasks
adiroiban
force-pushed
the
571-pre-commit-hooks
branch
from
1589dc8
to
e89304f
Compare
adiroiban
force-pushed
the
571-pre-commit-hooks
branch
from
f4dfb08
to
e9fd4eb
Compare
7 tasks
adiroiban
changed the title
|
This is ready for review. |
SmileyChris
approved these changes
May 21, 2024
Co-authored-by: Chris Beaven <smileychris@gmail.com>
|
Thanks for the review and feedback. I have triggered auto-merge on this PR. I have reconfigured the repo to allow merge commits
Previously, only squash merges were allowed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #571
Try to reproduce the reported error.
Besides using
pre-commitas part of our CIthis updates the release process to make it work with
pre-commit auto-update