Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render the issue reference when issue_format is not defined. #544

Open
thet opened this issue Sep 11, 2023 · 1 comment
Open

Don't render the issue reference when issue_format is not defined. #544

thet opened this issue Sep 11, 2023 · 1 comment
Labels

Comments

@thet
Copy link

thet commented Sep 11, 2023

I'd like to disable the issue reference for issue_template at all.
For one project we do not create issues which could be referenced.

Currently I'm doing a issue_format: "" in the pyproject.toml which generates empty parenthesis in the news entry like - NEWS TEXT. (). This is currently fine, but disabling would be even better.

@adiroiban
Copy link
Member

Hi Johannes

Thanks for the report. I think that it would be nice to have this functionality.

That is, if issue_format is empty, don't include the parenthesis.


I did a quick check for the code, and it looks like this is not an easy fix.

I was hopping to have all this generated via Jinja2, but it looks like there is custom python code.

def render_issue(issue_format: str | None, issue: str) -> str:

and

def render_fragments(

@adiroiban adiroiban changed the title Disable issue reference Don't render the issue reference when issue_format is not defined. Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants