Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't construct a KleinRequest via adaptation #378

Open
wsanchez opened this issue Jul 21, 2020 · 0 comments
Open

Don't construct a KleinRequest via adaptation #378

wsanchez opened this issue Jul 21, 2020 · 0 comments
Labels

Comments

@wsanchez
Copy link
Member

wsanchez commented Jul 21, 2020

In #359, @glyph notes:

The real problem here though appears to be that we are constructing a KleinRequest via adaptation - apparently for no good reason. Rather than lie about the type of mapper, I think it would make more sense to replace KleinResource.render's invocation with a simple KleinRequest(request, mapper).

Technically what I'm proposing is an incompatible change, but given that KleinRequest(request) gives you a nonsense non-functional object without an attached mapper, I'm OK with a short deprecation cycle here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant