Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: #39862 #39927

Closed
wants to merge 1 commit into from
Closed

Bug fix: #39862 #39927

wants to merge 1 commit into from

Conversation

rickygarim
Copy link

@rickygarim rickygarim commented Apr 27, 2024 •
edited by julien-deramond

Description

When you tab through an open modal, one complete cycle so that the focus goes from the last element on the modal back to the X [close] button, it causes the page to scroll where ever the modal is in the DOM order. This behavior is present in the current bootstrap site as well.

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39862

@rickygarim rickygarim requested a review from a team as a code owner April 27, 2024 01:03
@julien-deramond
Copy link
Member

Thanks for creating a PR @rickygarim
We haven't yet looked at the issue or this PR, but is there a way to create a unit test corresponding to the issue (failing without your fix, succeeding with your fix)?
There are also lint issues btw, you can run npm run lint locally to detect them.

@julien-deramond
Copy link
Member

In the corresponding issue, it states:

Scroll slightly so the "Launch Modal" button is slightly off screen but still clickable or scroll up so the button is almost at the bottom of the page and toggle the modal and tab through the modal

I've replicated this manipulation in the deployed version of this PR:

2024-05-25 08 42 53

It appears that the issue persists.

Note: Test conducted on macOS 14.4.1 / Firefox 126.0

Additionally, this PR has some lint issues and lacks associated unit tests. Therefore, I am closing it for now. If I have misunderstood the intended fix, or if you need more time to add the unit tests and resolve the lint issues, please feel free to comment and clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js needs tests v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completing a tab cycle inside a bootstrap modal will cause the page to scroll
2 participants
@rickygarim @julien-deramond