Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for replicate_index #2210

Open
daikitag opened this issue Oct 27, 2023 · 3 comments
Open

Documentation for replicate_index #2210

daikitag opened this issue Oct 27, 2023 · 3 comments

Comments

@daikitag
Copy link
Contributor

The replicate_index input in sim_ancestry function https://github.com/tskit-dev/msprime/blob/main/msprime/ancestry.py#L1100 is used repeatedly in various functions, but it is not documented in the docstring or the msprime documentation, and its usage is unclear. It might be better to document it or remove from the input.

@jeromekelleher
Copy link
Member

I'm not sure why we didn't document that @daikitag, and I'm honestly not sure whether it's really supported or not. We may have decided it wasn't worth the trouble of documenting.

@daikitag
Copy link
Contributor Author

I think it might be better to simply remove the argument from the sim_ancestry function, but what do you think about it? Since it is used in various functions, we can put replicate_index=None inside the function for now, and fix the other functions in the future release.

@jeromekelleher
Copy link
Member

I'm reluctant to change things like this without a good motivation. Let's have a look tomorrow to see if we can figure out why it's there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants