Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] hls's libspir contains unoptimized IR and some buggy IR #78

Open
Ralender opened this issue Sep 14, 2020 · 4 comments
Open

[SYCL] hls's libspir contains unoptimized IR and some buggy IR #78

Ralender opened this issue Sep 14, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Ralender
Copy link
Contributor

Ralender commented Sep 14, 2020

This is an HLS bug not a trisycl bug

the library is located at $XILINX_ROOT/Vitis/2020.1/lnx64/lib/libspir64-39-hls.bc and is shipped as part of Vitis
it isn't optimized, which increases build time and it contains some buggy functions like

; Function Attrs: alwaysinline nounwind
define spir_func float @erfc_impl(float %x) #29 {
  %retval = alloca float, align 4
  %x.addr = alloca float, align 4
  store float %x, float* %x.addr, align 4
  call void @llvm.trap()
  unreachable

1:                                                ; No predecessors!
  %2 = load float, float* %retval, align 4
  ret float %2
}
@Ralender Ralender added the bug Something isn't working label Sep 14, 2020
@keryell
Copy link
Member

keryell commented Sep 14, 2020

@aisoard @yu810226 any idea about how this code is generated? It looks like rubbish code...

@yu810226
Copy link

Seems to be completely useless code.

@keryell
Copy link
Member

keryell commented Sep 23, 2020

Any code coverage tools? :-)

@keryell
Copy link
Member

keryell commented Sep 23, 2020

@yu810226 I am curious about how this got generated. I let you fix this in HLS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants