Provider views rewrite (.files, .folders => .partialTree) #5050
+2,497
−1,659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoogleDrive - travelling down into folders works - checking a file works - breadcrumbs DONT work
eslint - fixing 2 eslint - fixing 3
This comment was marked as off-topic.
This comment was marked as off-topic.
…ed()` Clarification: `.toReversed()` is no supported by all browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enables indeterminate checkmark states
[fixes Nested folder selection does not work correctly #4609]
enables folder caching
fixes the issue where Unsplash was only loading one page
[fixes Unsplash doesn't load further pages #5000]
reworks restrictions system
[fixes Fix logic with adding folders toast message #4414]
In particular aggregate restrictions are now shown in the footer:
absDirPathandrelDirPathare injected in a single place[fixes https://github.com/Remote file paths #4537#discussion_r1260683896]
nOfSelectedFilesis as smart as it gets nowfixes the UI issue where shift-clicking files gets them highlighted:
fixes the way shift-clicking works in grid providers such as Instagram/Unpslash
[fixes Shift-clicking works chaotically with Instagram/Unsplash #5063]
makes the GoogleDrive's VIRTUAL_SHARED_DIR checkable
[see this discussion transloadit.slack.com/archives/C0FMW9PSB/p1714529071856209]
TODOs
For each provider, check if
1. signing in 2. checking deeply nested folders 3. downloading them 4. signing outworks.[To reviewers: I'll do it, no need to check all providers yourselves]
Some tests are failing atm - that's because of .ts/.tsx/no-extension import differences.
[To reviewers: I'll handle it while reviews are ongoing, shouldn't affect the code much]
TODOs for next PRs
I'll work on "mifi's PR + but custom handling for smaller n of files" in further PRs.
Notes to reviewers
.envin Slack - it's underway, but not yet fully ready.If you need access to a particular provider - message me, and I'll send you the credentials.
This PR spans 2.5k lines across 46 files.
I separated some PRs from this PR, however further separation will make it harder to review rather than easier, this is largely a holistic change.
I think a sane way to review this PR (apart from looking through "Files changed" on github) would be to look through the code in
/uppy/packages/@uppy/provider-viewsfolder locally in your editor - just read the files and see if they make sense/if something worries you. Most of these files were updated/rewritten.