Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global setting for success_fun & error_fun? #79

Open
shippy opened this issue Oct 15, 2018 · 1 comment
Open

Global setting for success_fun & error_fun? #79

shippy opened this issue Oct 15, 2018 · 1 comment

Comments

@shippy
Copy link

shippy commented Oct 15, 2018

I wanted to get feedback on potentially writing a PR implementing this. I'm imagining something along the lines of

options(assertr.success_fun = assertr::success_logical)

Use case: many independent chains, such that it's annoying to set success_fun for every assertr call / chain_end(success_fun = ...) call.

My current workaround is chain_end_quiet <- function(x) return(chain_end(x, success_fun = success_logical, error_fun = error_logical)), but that requires me to specify an assertr chain for each independent inquiry.

@tonyfischetti
Copy link
Owner

This seems like a great addition and I'd welcome it.
But, heads up, pretty soon there are going to a big merge into this repo (from a fork)
So you might want to wait until that happens before writing a PR.
Actually, I still haven't reviewed all the changes so this might actually already be addressed.
If its not, like I said, I think it'd be a great addition. Thanks for the interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants