Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite's Hot module replacement doesn't work with signia-react-jsx #67

Open
Lippiece opened this issue Mar 17, 2023 · 2 comments
Open

Vite's Hot module replacement doesn't work with signia-react-jsx #67

Lippiece opened this issue Mar 17, 2023 · 2 comments

Comments

@Lippiece
Copy link

Thank you for your work.

I've added jsxImportSource to tsconfig and vite config and observe that despite Vite reporting reacting to changes, they are not reflected in browser until manually refreshed.

May be related to preactjs/signals#250

@ds300
Copy link
Contributor

ds300 commented Mar 17, 2023

thanks for the report! ❤️

Just had a quick look into this, not 100% clear what's going on. It seems that by wrapping the components we're breaking some assumptions that the React fast refresh code makes. I'll ask in the vite plugin repo whether they have any tips.

@arpadgabor
Copy link

arpadgabor commented Apr 5, 2023

Is there any other issue that might track about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants