Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication between examples/atari/atari_network and examples/vizdoom/network #1092

Open
MischaPanch opened this issue Apr 3, 2024 · 1 comment
Open

Reduce duplication between examples/atari/atari_network and examples/vizdoom/network #1092

MischaPanch opened this issue Apr 3, 2024 · 1 comment
Labels
good first issue Good for newcomers refactoring No change to functionality

Comments

@MischaPanch
Copy link
Collaborator

Also names could maybe be improved. Things there are called DQN and so, even though they're just nets, while there's an independent class called DQNPolicy, which has nothing to do with these classes
@MischaPanch MischaPanch added refactoring No change to functionality good first issue Good for newcomers labels Apr 3, 2024
@MischaPanch
Copy link
Collaborator Author

Related to #944 and #988

This was previously a symlink, now it's a duplicate. I suspect that resolving #988 will also resolve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring No change to functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MischaPanch