Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefixes do not get recognized #34

Open
rvanlaak opened this issue Nov 12, 2019 · 1 comment · May be fixed by #35
Open

Prefixes do not get recognized #34

rvanlaak opened this issue Nov 12, 2019 · 1 comment · May be fixed by #35

Comments

@rvanlaak
Copy link

rvanlaak commented Nov 12, 2019 •
edited

While adding the Dutch language the van ’t last name prefix could not get detected.

Adding it to a new language's suffixes will not detect it either, so this has something to do with the parsing internals.

Did add a test in draft PR #35

Test data

Expected: Charlotte van ’t Wout

Actual: Charlotte Van ’T Wout
@rvanlaak rvanlaak linked a pull request Nov 12, 2019 that will close this issue
Draft
@blacksenator
Copy link

@rvanlaak I recognized the same problem for german particularities. I solved this with #40. If you are interested in this solution, than have a look on this PR - or even better: I would appreciate if you can test it. The prerequisite would be to create a Dutch.php likewise German.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recognize middle name van ’t scribbr/name-parser
2 participants
@rvanlaak @blacksenator