feat(wait_task): Add a wait_task module. #1647
Conversation
JGodin-C2C
force-pushed
the
develop
branch
4 times, most recently
from
6969c11
to
ef9df5a
Compare
|
@evgeni Failing tests does not seems to be part of my PR. |
|
They are, or at least partially. Have a look at the 3.10/2.12 sanity failures here: https://github.com/theforeman/foreman-ansible-modules/actions/runs/5612522667/job/15206459221#step:13:1 (The newer ansible versions fail for some reason, but that is certainly unrelated) I won't have time to properly review this PR before next week, but wanted to ask if you considered naming the module "wait_for_task" which (IMHO) would better fit with other wait_for_… modules that exist in Ansible core. |
|
A ! i see, the problem is WAY above the actual failure. I will fix. |
JGodin-C2C
force-pushed
the
develop
branch
5 times, most recently
from
8a69936
to
6b300fe
Compare
|
Seems much better. |
JGodin-C2C
force-pushed
the
develop
branch
2 times, most recently
from
d13e5ed
to
7c35d6c
Compare
JGodin-C2C
force-pushed
the
develop
branch
5 times, most recently
from
fac451c
to
49def46
Compare
And a new module that simply expose the wait_for_task function Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
|
All green ! 💪 |
|
Ok, what would be the next step to see this merged ? |
|
Me finding the time to finalize the review ;-) The only "real" thing I wanted/had to change were the tests -- I didn't like to have to do a full publish to get them to run and made them delete a product, which is also an async action we can wait on. While at it, I also extended the examples a bit ;-) As I couldn't push to your fork, I opened a second PR with your commit as the first one, and then my changes in mostly logical chunks: #1656 Once CI passes on that one I'll merge it (or you can pull the changes into this PR if you prefer to have the original one to be "closed as merged" -- I don't mind either way) |
|
merged as #1656 |
What :
And a new module that simply expose the wait_for_task function
This allows to wait for a asynchronous task to finish before continuing to apply the playbook.
How
It simply expose the function "wait_for_task" that was already available as a helper.
Related
fixes #1609
tests
Have been tested with a custom/minimal playbook on an internal satellite server.