Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit testing] Move internal bundle tests to the root tests folder #54

Open
6 tasks done
netsensei opened this issue Feb 2, 2018 · 1 comment
Open
6 tasks done

Comments

@netsensei
Copy link
Contributor

netsensei commented Feb 2, 2018

Detailed description

Currently, all the tests are spread out over the various internal bundles (a tests folder per bundle). It would be better to move the test classes to the more general tests folder which lives in the root of the Symfony project.

Context

This change is important because:

  • There's no need for tests in separated in bundles since we do not intend to release the core bundles as standalone packages.
  • It would allow us to consolidate all the fixtures we use for testing (currently XML files all over the place)
  • Less need for all kinds of bash scripts to run tests across folders.
  • Improve simplicity towards contributors who are willing to write tests.

Possible implementation

  • Move tests to the tests folder but following the namespacing and directory structure of the bundles.
  • Consolidate the fixtures in a separate fixtures folder. Consider removing them all together if possible.
  • Configure phpunit.xml properly.
  • Refactor the bash scripts in the scripts folder
  • Refactor .travis.yml accordingly
  • Document how tests should be run
@netsensei netsensei changed the title Move internal bundle tests to the root tests folder [Unit testing] Move internal bundle tests to the root tests folder Jun 21, 2018
@netsensei netsensei added this to the Version 1.0 milestone Sep 14, 2018
@netsensei
Copy link
Contributor Author

We moved all tests to a seperate tests/ folder. But we still have work left with managing fixtures. These are currently still a part of the src bundles, not the tests bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants