Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the internal bundles #51

Open
netsensei opened this issue Jan 30, 2018 · 0 comments
Open

Rename the internal bundles #51

netsensei opened this issue Jan 30, 2018 · 0 comments
Milestone

Comments

@netsensei
Copy link
Contributor

Detailed description

There's a difference between the bundle (folder) name and the class name. This is very confusing:

OAuthBundle > DataHubOauthBundle
SharedBundle > DataHubSharedBundle
UserBundle > DatahubUserBundle
OAIBundle > DataHubOAIBundle
ResourceBundle > DataHubResourceBundle
ResourceAPIBundle > DataHubResourceAPIBundle

Context

Do we need the 'DataHub' prefix for each bundle? Omitting that would make things more clear and maintainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant