Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the SharedBundle bundle #50

Open
3 of 6 tasks
netsensei opened this issue Jan 25, 2018 · 1 comment
Open
3 of 6 tasks

Deprecate the SharedBundle bundle #50

netsensei opened this issue Jan 25, 2018 · 1 comment
Milestone

Comments

@netsensei
Copy link
Contributor

netsensei commented Jan 25, 2018

Detailed description

The SharedBundle bundle contains a lot of "general" code which is called in the other bundles such as traits, templates, functions. It also contains the DefaultController which has the Dashboard action. And finally, it has the app:setup command and a few fixtures.

Context

The Bundle itself doesn't serve a real purposes. It's just something other bundles depend upon. As such, it violates the Single Responsibility Principle. Deprecating the module would vastly improve maintainability and testability of code.

Possible implementation

Breaks down in these tasks:

  • Remove SharedBundle\Helper\SerializationHelper
  • Move EnvironmentSpecificDataFixture to UserBundle & OAuthBundle
  • Move DefaultController to DashboardBundle
  • Deprecate Traits and integrate them in bundles
  • Move Resources\views to App\Templates
  • Move views to App\templates (or Assets?)
@netsensei
Copy link
Contributor Author

Move Resources\views to App\Templates
See: 1913950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant