Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about browser implementation. #27

Open
gmikeska opened this issue Jan 26, 2015 · 6 comments
Open

Question about browser implementation. #27

gmikeska opened this issue Jan 26, 2015 · 6 comments

Comments

@gmikeska
Copy link

I have browserfied the source, but I am having trouble getting computers to link to one another. Do you need to have more than one encryption type enabled? Though it is noted that cs2a is supported in the browser, it seemed like having it in the browserfied js was causing an issues, so I took it out.

@quartzjer
Copy link
Member

You're encountering some work that was just done this weekend and not very well tested yet, I plan to get to a round of browser testing this week, but it's likely to be unstable before then.

If you have any suggestions as to how to hook up travis to do automated browser testing I'm all ears, I haven't gone down that rabbit hole yet but I'm hoping to :)

@gmikeska
Copy link
Author

I see... As soon as I get a chance I will try to learn travis and will try to get it hooked up. I believe that telehash will end up being a very important library and I want to do all I can to help implement it!

@quartzjer
Copy link
Member

I have a super simple browser example working now for me, could you update and see if it does for you too? https://github.com/telehash/telehash-js/blob/master/test/browser/load.html

@gmikeska
Copy link
Author

Hey... It generated IDs this time, but it looks like it had trouble
connecting to the router (I, for this example, had the router set up on a
heroku instance and was trying to connect to it from my home network). Do
any specific ports need to be open for this to work?

On Thu, Jan 29, 2015 at 1:17 PM, Jeremie Miller notifications@github.com
wrote:

I have a super simple browser example working now for me, could you update
and see if it does for you too?
https://github.com/telehash/telehash-js/blob/master/test/browser/load.html


Reply to this email directly or view it on GitHub
#27 (comment).

Greg Mikeska
Texas A&M Class of 2007
MakerSquare C10 Student

@quartzjer
Copy link
Member

Sorry I didn't respond sooner, but it should work on heroku if the http port is open/assigned correctly, I'll file an issue and test this out...

@southbite
Copy link

Could one of you chaps help me browserify the source? I have done it, but the minify part breaks, so I took that out of the pipleline, now when I test my browserified code using karma, I get Uncaught TypeError: Cannot read property 'tcpServer' of undefined when running exactly the same test code that works on server side (in node) - is there a version of telehash you recommend I browserify?

Ah right - you just run "npm run browserify" - I moved telehash into my own project and attempted browserify - with not so good results... May make sense to document this, unless it is something that most people should now and I am just unaware of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants