New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add transports to default extensions #23
Comments
👍 this should be easier and more obvious, good feedback. If you take a look at the tests you'll see that you can pass in a fixed list of extensions when you create a mesh that will override, is that helpful? |
I think it's good to always have all default channel extensions (from the Also how about more advanced unregister/config API for extensions? E.g. to allow users to add/remove extensions by type (channel, transport, cipher), option to disable all extensions and so on. Another note: I'm note sure it's generally good idea to listen on some port by just adding the transport. Or maybe all transports should be splitted into the client and server parts (like http-client and http-server) so the users can choose essential functionality? |
I think it would make sense to have something like Only the registered extensions should be available. Same for ciphersets and other things. |
Yes, I very much want to move to this model here too, it's near the top of my TODO list now so it should happen soon :) |
By running this simple mesh node creates 3 listening sockets: two for TCP and one for UDP:
That's because of the transport extensions added by default on module load.
I could unload them by calling:
but it looks ugly as for me. (Also little bug: extensions should be an object.)
Should it be the option to disable default extensions without manually removing them?
The text was updated successfully, but these errors were encountered: