Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Do not panic if getting SAML metadatdata fails #1445

Closed
2 tasks done
FreddyDevelop opened this issue Apr 23, 2024 · 2 comments · Fixed by #1464
Closed
2 tasks done

[FEAT]: Do not panic if getting SAML metadatdata fails #1445

FreddyDevelop opened this issue Apr 23, 2024 · 2 comments · Fixed by #1464
Assignees
@shentschel
Labels
enhancement New feature or request

Comments

@FreddyDevelop
Copy link
Contributor

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Description

Currently Hanko gets metadata for all SAML connections on startup and when a call to a metadata endpoint fails (e.g. http code > 400, wrong response body) Hanko won't start.

Describe your ideal solution

Hanko should show a warning in the logs when it fails to get SAML metadata, but should start anyway.

Workarounds or alternatives

No response

Hanko Version

v0.10.2

Additional Context

No response
@FreddyDevelop FreddyDevelop added the enhancement New feature or request label Apr 23, 2024
@shentschel
Copy link
Collaborator

So we want to ignore that provider after the warning?

@shentschel shentschel self-assigned this May 17, 2024
@FreddyDevelop
Copy link
Contributor Author

So we want to ignore that provider after the warning?

Yes

shentschel pushed a commit that referenced this issue May 17, 2024
feat(saml): make getting providers from metadata non-panic
4ecb690 
* show a warning if a provider cannot be fetched by its metadata url
* skip the provider in provisioning state

Closes: #1445
shentschel pushed a commit that referenced this issue May 17, 2024
feat(saml): make getting providers from metadata non-panic
c4e31bd 
* show a warning if a provider cannot be fetched by its metadata url
* skip the provider in provisioning state

Closes: #1445
@shentschel shentschel mentioned this issue May 17, 2024
Merged
shentschel pushed a commit that referenced this issue May 29, 2024
chore(provider): add provider name to error message
30dfdb1 
adds the idp config provider name to error message when
the provider host cannot be parsed from metadata url or
fetching metadata document fails.

Closes: #1445
FreddyDevelop pushed a commit that referenced this issue Jun 6, 2024
@shentschel
feat(saml): make getting providers from metadata non-panic (#1464)
d551f32 
* feat(saml): make getting providers from metadata non-panic

* show a warning if a provider cannot be fetched by its metadata url
* skip the provider in provisioning state

Closes: #1445

* chore(provider): add provider name to error message

adds the idp config provider name to error message when
the provider host cannot be parsed from metadata url or
fetching metadata document fails.

Closes: #1445

---------

Co-authored-by: Stefan Jacobi <stefan.jacobi@adesso.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shentschel shentschel

Labels
enhancement New feature or request
Projects
Hanko
Status: ✅ Recently closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(saml): make getting providers from metadata non-panic teamhanko/hanko
2 participants
@shentschel @FreddyDevelop