Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use disk image mtime/ctime for comparing snapshots #147

Closed
tasket opened this issue Mar 23, 2023 · 2 comments
Closed

Option to use disk image mtime/ctime for comparing snapshots #147

tasket opened this issue Mar 23, 2023 · 2 comments
Labels
enhancement New feature or request optimization
Milestone

Comments

@tasket
Copy link
Owner

tasket commented Mar 23, 2023

A not-so-corner case is where a Wyng user wants to perform frequent backups from very large volumes, even though some of those volumes rarely change. Despite Wyng's existing speed at detecting changes, significant amounts of time can be saved in this use case if Wyng has some way to skip the update_delta_digest() process.

An option like --compare-mtime could be added Since most backup utilities use mtime or ctime, this method could be considered a reliable default for Wyng too, and could shave minutes off monitor and send operations when Petabyte and larger-sized volumes are involved.

It seems this would only work for reflink type storage, not LVM.

@tasket tasket added the enhancement New feature or request label Mar 23, 2023
@tasket
Copy link
Owner Author

tasket commented Jun 15, 2023

To clarify:

During snapshot preparation, the following would be treated as unchanged:

  1. deltamap for the volume is empty.
  2. and the mtimes and sizes between snap1 and snap2 match completely.

The current code does this check to compare the source volume, but doesn't explicitly compare snap1/snap2.

@tasket tasket added this to the v0.9 milestone Jun 15, 2023
@tasket tasket modified the milestones: v0.9, v0.8 Jun 30, 2023
@tasket tasket changed the title Option to use disk image mtime for comparing snapshots Option to use disk image mtime/ctime for comparing snapshots Jun 30, 2023
@tasket
Copy link
Owner Author

tasket commented May 17, 2024

This has been implemented in prepare_snapshots_reflink() and uses the approach of comparing the timestamp of snap1 with that of the source volume.

@tasket tasket closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization
Projects
None yet
Development

No branches or pull requests

1 participant