Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make sure simulation_state components can be properly modified by the solvers, such as the v_inner_solver in the future implementation #2515

Open
DeerWhale opened this issue Feb 7, 2024 · 1 comment

Comments

@DeerWhale
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In order to solve the v_inner_boundary iteratively, the solver should have the ability to update the properties in simulation_state (including geometry and other components that depends on geometry, such as radiation_field_state.) This is roughly done in PR #2504, but might be more efficient way. Need to double check if the parts in the model/parse_input.py are only setting up initial values (such t_rad and dilution factor initial values) and the properties that the solvers need to be update live outside the parser.

@DeerWhale
Copy link
Contributor Author

Also check if shrinking the first cell is better or just use the original shell grid is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant