New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover edge case for zero `ion_number_density` in NLTE `check_negative_population` #2482

Open

AlexHls opened this issue Nov 29, 2023 · 0 comments

Labels

plasma priority - low 🐌

Member

AlexHls commented Nov 29, 2023

tardis/tardis/plasma/properties/nlte_rate_equation_solver.py

Line 384 in 4076649

if number_density.loc[atom_number] == 0.0:

This edge case is covered very rudimentary, but there is probably a smarter way to cover this case.

AlexHls added plasma priority - low 🐌 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment