Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No fallback on visibility controls (other settings may not either) #146

Open
boberfly opened this issue Apr 19, 2021 · 2 comments · Fixed by #151
Open

No fallback on visibility controls (other settings may not either) #146

boberfly opened this issue Apr 19, 2021 · 2 comments · Fixed by #151
Labels
bug Something isn't working

Comments

@boberfly
Copy link
Contributor

Currently when you specify different visibility flags to objects in Solaris, the viewport will update this state however if you set these controls to "Do Nothing" (essentially removing the attributes from the schema) the viewport doesn't revert back to the Cycles defaults and just sticks to the last thing that it was set to.

However, when re-loading the scene from a fresh Houdini instance or rendering to husk it'll do the right thing, as the defaults are there from a fresh initialisation. I am wondering now if this is just for visibility flags, or that hdcycles might need to have a way to always fallback to defaults for all settings.

@boberfly boberfly added the bug Something isn't working label Apr 19, 2021
@boberfly
Copy link
Contributor Author

Having a deep-dive if I could solve this one myself, for object/mesh/curve/volume/lights I can set the actual default value by hand from what cycles is set to, but it would be preferred to get the default value from the schema itself.

I also saw all of renderParam.cpp it is just feeding in the previous value as default value, which is wrong as it should be the default value that is set at init time (the default built into cycles values and not just the previous value which will change as the user changes values in a running session).

@boberfly
Copy link
Contributor Author

Potential fix:
#151

@bareya bareya linked a pull request Apr 27, 2021 that will close this issue
@bareya bareya added this to Needs triage in HdBlackbird Development via automation May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant