Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard-coded fan assumptions with configs #453

Open
crawfxrd opened this issue Apr 29, 2024 · 0 comments
Open

Replace hard-coded fan assumptions with configs #453

crawfxrd opened this issue Apr 29, 2024 · 0 comments

Comments

@crawfxrd
Copy link
Member

crawfxrd commented Apr 29, 2024 •
edited

There are some hard-coded assumptions around fans that need to be addressed:

  • There is 1 CPU fan
    • It uses PWM2 (DCR2)
  • There is 1 dGPU fan
    • It uses PWM4 (DCR4)

darp10 is a unit without a dGPU, but has 2 CPU fans. They use PWM2 and PWM3.

It should be possible for a board to specify which interface each fan uses.

Info that's probably needed for each fan:

  • PWM index (DCR[0-7]) for setting duty
  • Tachometer (TACH[0-2][AB]) for tracking/reporting RPM?
  • Min/max duty/RPM for each fan

Shoving it all in the Makefile probably won't work, requiring some rewriting of the common and board-level logic.

Additionally, the temperature sensors should be pulled out and be separate from the fan control, but that fits more with #390.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crawfxrd