Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default charge thresholds need to match profile #143

Open
ids1024 opened this issue Feb 1, 2021 · 1 comment
Open

Default charge thresholds need to match profile #143

ids1024 opened this issue Feb 1, 2021 · 1 comment

Comments

@ids1024
Copy link
Member

ids1024 commented Feb 1, 2021

The default thresholds should match one of the charging profiles offered through system76-power/gnome-control-center.

I guess we're still sorting out exactly how we want to handle this, but it seems good to have an issue for it.

See pop-os/system76-power#197 and pop-os/gnome-control-center#140.

@crawfxrd
Copy link
Member

EC firmware should not have knowledge of profiles, only the start/stop values. Default values of a profile can be set in common.mk.

# Set battery charging thresholds
BATTERY_START_THRESHOLD?=0
BATTERY_END_THRESHOLD?=100

TLP has also added support to System76 Open Firmware, so it should be updated as well if this change is made.

https://github.com/linrunner/TLP/blob/45ca3a6c8cf651eafd75b70dcc67065c6902dcda/bat.d/45-system76#L83-L85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants