Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive obsolete article about battery percentage setting #1202

Closed
wants to merge 2 commits into from

Conversation

ahoneybun
Copy link
Member

This moves the article to be archived since it is no longer valid information.

jacobgkau
jacobgkau previously approved these changes Dec 19, 2023
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree that this article isn't really needed anymore if it's just detailing one setting in the default Settings app.

This is working when I test it locally (the article doesn't show up in the list or search), so I'm approving. However, you may also want to change hidden to true since that seems to be the case for most of the other articles in the archived directory.

@jacobgkau jacobgkau linked an issue Dec 19, 2023 that may be closed by this pull request
@jacobgkau jacobgkau changed the title Address issue 1201 Archive obsolete article about battery percentage setting Dec 19, 2023
jacobgkau
jacobgkau previously approved these changes Dec 19, 2023
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More descriptive commit messages would be nice to work on in the future.

@jacobgkau
Copy link
Member

Was that commit on the codecs article supposed to go into the same PR as the battery percentage article archival?

@ahoneybun ahoneybun closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery percentage article is out of date.
2 participants