isTtySupported() does not take into account open_basedir() restrictions #54874
Comments
|
Ping @Yurunsoft |
|
Fixed by #54863 |
xabbuh
added a commit
that referenced
this issue
May 15, 2024
…ss to `/dev/tty` (mjauvin) This PR was merged into the 6.4 branch. Discussion ---------- [Process] Return `false` when `open_basedir` prevents access to `/dev/tty` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no If open_basedir restrictions are in effect, checking if the file /dev/tty is writable will prevent setting tty mode on the process, and avoid failing to create a Process. Fixes #54874 Commits ------- 825e38b Return false in isTtySupported() when open_basedir restrictions prevent access to /dev/tty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected
>= 6.2Description
In 007fa61 / #46971 the logic that checks if TTY is supported changed from checking
/dev/ttyfor reading / writing capabilities directly to checkingstream_isatty(\STDOUT).This causes an issue because the new way fails to take into account the open_basedir restrictions.
Related: wintercms/storm#175
How to reproduce
open_basedirrestriction not in effect, works fine:php -r "require_once(__DIR__ . '/vendor/autoload.php'); (new \Symfony\Component\Process\Process(['ls', '-lsa']))->setTty(true)->run();"open_basedirrestriction in effect, causes hard crash withPHP Fatal error: Uncaught Symfony\Component\Process\Exception\RuntimeException: Unable to launch a new process. in vendor/symfony/process/Process.php:350:Possible Solution
Revert the linked commit or add an additional
is_writable('/dev/tty')check.Additional Context
Side note, can we change the
self::isTtySupported()call tostatic::isTtySupported()instead so that extending classes can override just the relevant method if needed in the future instead of having to override thesetTty()method entirely?The text was updated successfully, but these errors were encountered: