New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] include a new dev dependency twig-cs-fixer
in the codebase
#54799
Comments
For context it was added by @smnandre in symfony/ux |
... only on the website (for now) :) Regarding the suggestion, did you run it on the Symfony codebase ? Does it change a lot of files ? Only in "test / fixtures" or in Resources also ? That'd be nice to know the "impact" i think :) |
I didn't run it everywhere but I already found some issues like #54051 |
None of the tools we use (PHPUnit, PHP-CS-Fixer, Psalm) is an actual dev dependency on this repo. I don't think we want to change that. |
yes I perhaps miswrite my purpose, more like adding a
nope, but I can of course and report back here when I 've done it |
with a default config file, and the latest version of the fixer looks like major things are spacing inside arrays and around operators |
Should it be fabbot's responsibility? |
@chalasr If so, it should probably be Symfony specific then (at least at first) ? |
@smnandre Perhaps yes, I don't know much about fabbot internals as it's not public code yet. I'd expect it to run tools like php-cs-fixer only if a matching config file exists in the project. I may be wrong though. |
Description
Hello
May I propose to add the tool
twig-cs-fixer
(repo) in this repo as a dev dependencyRFC
What?
php-cs-fixer
, but for twig filesWhy?
How?
Thank you!
friendly ping @VincentLanglet and our discussion here
Example
No response
The text was updated successfully, but these errors were encountered: