evil-ex-search skips matches in folded regions (in org-mode)

[sainathadapa]

Description

When using evil-ex-search-forward (/) in a org file, I should be able to navigate to matches in all regions and navigating to matches in folded regions should unfold the region.

Reproduction guide 🪲

• Start Emacs
• Open a org file, and activate evil mode if it wasn't already
• Collapse all sections
• Search for a string within one of the collapsed sections

Observed behaviour: 👀 💔
No matches found

Expected behaviour: ❤️ 😄
Evil should find the word within the collapsed section, and navigate to it. (Expand the sections if necessary)

System Info 💻

• OS: darwin
• Emacs: 29.1
• Spacemacs: 0.999.0
• Spacemacs branch: develop (rev. b86a074)
• Graphic display: t
• Running in daemon: nil
• Distribution: spacemacs
• Editing style: vim
• Completion: helm
• Layers:

((org :variables org-enable-bootstrap-support t org-want-todo-bindings t)
 auto-completion
 (spell-checking)
 syntax-checking deft emacs-lisp html lsp markdown git helm
 (osx :variables osx-command-as 'control osx-option-as 'meta osx-control-as 'hyper osx-function-as nil osx-right-command-as 'left osx-right-option-as 'left osx-right-control-as 'left osx-swap-option-and-command nil))

• System configuration features: ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB

Backtrace 🐾

N/A

[sainathadapa]

The above issue is similar to this issue I found within doomemacs repo - doomemacs/doomemacs#6478

[davidpiano]

I'm having the same problem.

[smile13241324]

This seems to be an issue between org and evil-search as both use different methods for marking folded text.

The more modern solution for folding tests is "overlays" therefore we need to force org to use it. We can do this by setting "org-fold-core-style" to "overlays" in the org layer.

[davidpiano]

"Overlays" is less modern, not more. After reading what org gains by using its newer folding method, I'd prefer to give up evil-ex-search in return for it.

[smile13241324]

Sorry my mistake. Jep then lets go the other way around.

After some more reading into the details I would also go with text properties they seem to be less demanding on the CPU when appearing in huge numbers. I hope we do not loose other features by falling back to 'Isearch' though.